Skip to content

Fix #5812: Compactify names when flattening #11279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Feb 2, 2021

This is intended to replicate the behavior of Scala 2.13, where classfile names are limited to 240 characters.

Fixes #5812

[test_windows_full]

This is intended to replicate the behavior of Scala 2.13, where
classfile names are limited to 240 characters.
@griggt
Copy link
Contributor Author

griggt commented Feb 2, 2021

I suppose we need to consider scala/scala#7483.

Also, should we test that the compactified names match those generated by Scala 2.13? (a cursory inspection of the classfiles created by t8199.scala seems to indicate that this is indeed the case)

@griggt griggt self-assigned this Feb 2, 2021
@griggt
Copy link
Contributor Author

griggt commented Feb 4, 2021

The Scala 2 compat test succeeds on lampsrv26 but fails on lampsrv9 with java.nio.file.FileSystemException: ... File name too long.

Perhaps they are using different Docker storage drivers. The file name is currently 244 characters long, I'll shorten it slightly. I think the max for aufs is 242.

https://github.com/lampepfl/dotty/actions/runs/535610971

@griggt griggt marked this pull request as ready for review February 4, 2021 08:13
@griggt griggt requested a review from smarter February 4, 2021 16:53
@griggt griggt assigned smarter and unassigned griggt Feb 4, 2021
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smarter smarter merged commit 65e8c40 into scala:master Feb 4, 2021
@griggt griggt deleted the fix-#5812 branch February 4, 2021 17:09
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove -Xmax-classfile-name; hard-code to 240, like Scala 2.13.0-RC1
3 participants