Init: Promote this after all its fields have been initialized
#11278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Thanks @natsukagami. While you are on it, could you incorporate some of the improvements in #10627 (excluding promotion of warm), in this PR or a new one? It will make subsequent work easier.
| class P() { | ||
| val a = 1 | ||
| List(this) | ||
| } |
There was a problem hiding this comment.
It would be good to add a test that a warm inner class object promotes to hot because of the outer object being hot.
| if (allFieldsInited) | ||
| Errors.empty | ||
| else | ||
| PromoteThis(pot, eff.source, state2.path).toErrors |
There was a problem hiding this comment.
It might be good to cache safely promoted potentials to avoid re-computation. See #10627.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initialization checker will now accept uses of
thisandthis-referencing objects as fully-initialized objects ("hot") after allvaldeclarations have been evaluated.Simple example:
A simple test is included.
This change is