Use all available context info for healing ambiguous implicits #11274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
fix-11243
branch
2 times, most recently
from
ce08e50 to
b847f6f
Compare
When retrying after an ambiguous implicit, we now make use of all the information in the prototype, including ignored parts. We also try to match formal parameters with actually given arguments. Fixes scala#11243 Fixes scala#5773, which previously was closed with a more detailed error message.
|
Does this by chance also fix #7069? |
|
@prolativ Does not look likely. |
|
test performance please |
|
performance test scheduled: 36 job(s) in queue, 1 running. |
smarter
approved these changes
Feb 2, 2021
| i"""normalizedCompatible for $poly, $pt = $result | ||
| |constraint was: ${ctx.typerState.constraint} | ||
| |constraint now: ${newctx.typerState.constraint}""") | ||
| val existingVars = ctx.typerState.uninstVars.toSet |
There was a problem hiding this comment.
This could be a def or moved inside the if condition to avoid calling toSet unnecessarily.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11274/ to see the changes. Benchmarks is based on merging with master (524a129) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrying after an ambiguous implicit, we now make use of all the
information in the prototype, including ignored parts. We also try
to match formal parameters with actually given arguments.
Fixes #11243
Fixes #5773, which previously was closed with a more detailed error message.