Improve variable instantiation when member is missing #11242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `couldInstantiateTypeVar` method instantiated only type variables that were the constructor of an applied type. But sometimes we might also need to instantiate the argument(s), since doing so can influence the members of the applied type. This happens in two cases 1. The applied type's rhs is a match type 2. The applied type's result is one of its type parameters i11236.scala tests the first case, the additions to i9567.scala the second. Fixes scala#11236
|
There is a related issue that did not get fixed with these changes (see #11236). |
nicolasstucki
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
couldInstantiateTypeVarmethod instantiated only type variablesthat were the constructor of an applied type. But sometimes we
might also need to instantiate the argument(s), since doing so can
influence the members of the applied type. This happens in two cases
i11236.scala tests the first case, the additions to i9567.scala the second.
Fixes #11236