Skip to content

Fix deprecation for java.lang.Deprecated #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix deprecation for java.lang.Deprecated #11216

merged 2 commits into from
Feb 1, 2021

Conversation

BarkingBad
Copy link
Contributor

No description provided.

@BarkingBad BarkingBad linked an issue Jan 26, 2021 that may be closed by this pull request
Handle java.lang.Deprecated annotation same way as we do with scala.deprecated #11086
Closed
@BarkingBad BarkingBad mentioned this pull request Jan 27, 2021
Merged
@BarkingBad BarkingBad force-pushed the scala3doc/java-deprecated-annotation branch from 471271b to 296289d Compare February 1, 2021 09:15
romanowski
romanowski reviewed Feb 1, 2021
View reviewed changes
@BarkingBad BarkingBad merged commit 9c9d4ec into scala:master Feb 1, 2021
@BarkingBad BarkingBad deleted the scala3doc/java-deprecated-annotation branch February 1, 2021 22:59
@griggt
Copy link
Contributor

griggt commented Feb 2, 2021

This has caused CI breakage on JDK 8

https://github.com/lampepfl/dotty/runs/1811701716?check_suite_focus=true#step:8:142

Error:  -- Error: /__w/dotty/dotty/scala3doc-testcases/src/tests/deprecated.scala:22:28 
Error:  22 |@java.lang.Deprecated(since = "1.1")
Error:     |                      ^^^^^^^^^^^^^
Error:     |constructor Deprecated in class Deprecated: (): Deprecated does not have a parameter since
Error:  one error found

@BarkingBad
Copy link
Contributor Author

Sorry for the trouble, didn't see it coming as PR had passed all smaller checks

@griggt
Copy link
Contributor

griggt commented Feb 2, 2021

#11280

@nicolasstucki
Copy link
Contributor

Tho avoid these kinds of failures it is good to use Java 8 on the Dotty project. If it works with 8 it most likely works with later versions we support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanowski romanowski romanowski approved these changes

@pikinier20 pikinier20 Awaiting requested review from pikinier20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle java.lang.Deprecated annotation same way as we do with scala.deprecated
4 participants
@BarkingBad @griggt @nicolasstucki @romanowski