Skip to content

Fix trace command for effect.asSeenFrom #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2021
Merged

Fix trace command for effect.asSeenFrom #11200

merged 1 commit into from
Jan 24, 2021

Conversation

natsukagami
Copy link
Contributor

@natsukagami natsukagami commented Jan 24, 2021 •
edited
Loading

Fix the trace callback in Effect.asSeenFrom. Previously the callback was called as if it is expecting an Effects object (not Effect), causing it to crash from the downcast.

This change is Reviewable

liufengyun
liufengyun approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @natsukagami 🎉

@liufengyun liufengyun merged commit a0aea99 into scala:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natsukagami @liufengyun