Add mode bit to track whether we are in safe nulls mode #11195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noti0na1 This might be a good basis for the explicit-nulls PR. |
|
@odersky Thanks! I will take a look |
|
I have merged this branch into my PR. |
noti0na1
requested changes
Jan 26, 2021
Make sure that something is a language import if and only if it
looks like one. i.e. is of one of the forms
import language.xyz
import scala.language.xyz
import _root_.scala.language.xyz
Avoid a notation of "owner" when checking for a language feature. Instead, allow qualified names for language features, e.g. `experimental.dependent".
The bit is set if - -Yexplicit-nulls is set - we are not in an `import.unsafeNulls` scope
odersky
force-pushed
the
add-safenull-mode
branch
from
72349bd to
1f993b7
Compare
noti0na1
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bit is set if
import.unsafeNullsscope