-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #11078: avoid widening F-bounds in type avoidance #11192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
trait Foo[A <: Foo[A]] | ||
trait FooCreator[A <: Foo[A]] { | ||
def createFoo(): A | ||
} | ||
|
||
trait FooWrapper { | ||
type A <: Foo[A] | ||
def foo: A | ||
} | ||
object FooWrapper { | ||
def apply[A0 <: Foo[A0]](toWrap: A0): FooWrapper { type A = A0 } = new FooWrapper { | ||
type A = A0 | ||
def foo: A0 = toWrap | ||
} | ||
} | ||
|
||
trait FooCreatorWrapper { | ||
type A <: Foo[A] | ||
def fooCreator: FooCreator[A] | ||
} | ||
|
||
sealed trait Bar | ||
object Bar { | ||
case class Baz(wrapper: FooCreatorWrapper) extends Bar | ||
} | ||
|
||
def process(bar: Bar): FooWrapper = bar match { | ||
case Bar.Baz(wrapper) => FooWrapper(wrapper.fooCreator.createFoo()) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class Test { | ||
trait Foo[A <: Foo[A]] | ||
|
||
trait FooWrapper with self => | ||
type A <: Foo[A] | ||
def doThing(foo: FooWrapper): FooWrapper { type A = self.A } = ??? | ||
end FooWrapper | ||
|
||
val foos: scala.Seq[FooWrapper] = ??? | ||
val newFoo = foos.foldLeft(??? : FooWrapper)((topFoo, foo) => topFoo.doThing(foo)) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the standard tryWiden shouldn't widen f-bounds either?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a trial to see how it works. It may incur a performance penalty.
If it works, I think we need a more systematic approach here: possible a field in SymDenotation to cache whether a symbol is F-bounded. The field can be set in
checkNonCyclic
, so we can avoid the computation here (or inApproximatingTypeMap
).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F-bounded situations are already captured by LazyRefs. Maybe just add a case for LazyRefs to TypeOps.avoid?
Oh, I see you tried that already.