Remove octal escape literals #11140
Merged
Remove octal escape literals #11140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
commented
Jan 17, 2021
| val chr1 = '\0' // error | ||
| val str1 = "abc\123456" // error | ||
| val lf = '\012' // error | ||
| } |
som-snytt
reviewed
Jan 18, 2021
| @@ -1157,6 +1158,8 @@ object Scanners { | |||
| nextChar() | |||
| } | |||
| } | |||
| val alt = if (oct == LF) "\\n" else "\\u%04x" format oct | |||
There was a problem hiding this comment.
if oct == LF then raw"\n" else f"\u$oct%04x" for style points?
Closes scala#10895 Ref scala/scala#6324 This PR removes octal escape in String literals, which was deprecated and removed in scala 2.
tanishiking
force-pushed
the
octal-escape-literal
branch
from
c571618 to
64aa7cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10895
Ref scala/scala#6324
This PR removes octal escape in String literals, which was deprecated and removed in scala 2.