Fix #11118: check irrefutable pattern def in 3.0 #11131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-i11118
branch
3 times, most recently
from
0a2df5b to
83f7c71
Compare
After scala#10793, we can perform the check in 3.0
liufengyun
force-pushed
the
fix-i11118
branch
from
83f7c71 to
3ce2c15
Compare
liufengyun
force-pushed
the
fix-i11118
branch
from
3ce2c15 to
77730eb
Compare
|
@sjrd Could you please advise how to fix the following error in managed scala.js code: Error: -- Error: /__w/dotty/dotty/out/bootstrap/scala3-compiler-bootstrapped/scala-3.0.0-RC1/src_managed/main/scalajs-ir-src/org/scalajs/ir/Trees.scala:1149:34
Error: 1149 | val StringLiteral(name) = propName
Error: | ^^^^^^^^
Error: |pattern's type org.scalajs.ir.Trees.StringLiteral is more specialized than the right hand side expression's type org.scalajs.ir.Trees.Tree
Error: |
Error: |If the narrowing is intentional, this can be communicated by adding `: @unchecked` after the expression. |
|
Close for now, enabling it in 3.0 seems problematic, it's better to delay until 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11118: check irrefutable pattern def in 3.0
After #10793, we can perform the check in 3.0