Value classes: add support for private[this] parameter

[VladimirNik]

Allow private[this] parameter in value classes:

class A(x: Int) extends AnyVal
class B(private[this] val x: Int) extends AnyVal

Review by @odersky @DarkDimius

[odersky]

I don't think it will work that way. You'll need to create a public accessor for the private field and have all unboxing operations go through the accessor instead of the field.

[DarkDimius]

I believe that the easiest implementation would be to drop Private | PrivateLocal flags from fields inside value classes just after pickling.

[odersky]

That won't work because you might get accidental overrides. If you drop the
flags you need to mangle the name at the same time. But in any case a
non-private parameter is represented as a private field
and a non-private getter. So you might just add the getter and leave the
field in place.

On Fri, Feb 19, 2016 at 5:40 PM, Dmitry Petrashko [email protected]
wrote:

I believe that the easiest implementation would be to drop Private |
PrivateLocal flags from fields inside value classes just after pickling.

—
Reply to this email directly or view it on GitHub
#1112 (comment).

Martin Odersky
EPFL

[VladimirNik]

Update: tests failed due to neg_valueClasses test (I forgot to update the number of errors in tests.scala). Now it's fixed.

[odersky]

LGTM. That was surprisingly simple. Nice!