Special case pattern matching against abstract types with class tags #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #1105. |
Tests failures were caused by previous incomplete implementation of classTag.
Now diagnoses missing ClassTags of abstract types as implicit failures. Also: Simpler API of tpd.clsOf.
If a classtag for `T` is available, a classtag for `Array[T]` can also be generated.
Context bounds did not make it before into secondary constructors. Now the evidence parameters generated by context bounds get copied into secondary constructors. Without this fix, scala.collection.immutable.PagedSeq fails to compile in new classtag scheme.
Make use of Definitions as the repository for standard symbols in Predef.
Now subsumed by functionality in Typer.
Goal: Make implementation easier to understand. Prepare the ground for special-casing of typetagged patterns.
Add special case when pattern matching against an abstract type that comes with a class tag
We do not want to do implicit search during tree checking.
|
Rebased to master |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Mar 2, 2016
Special case pattern matching against abstract types with class tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099. Review by @DarkDimius