Improve handling of disjunctions when comparing types #11083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems in a comparison
A | B <: C
1. If the LHS was `a.type | Nothing`, atoms computation
did not correctly account for Nothing.
2. For other comparisons, the preliminary widen test was
not done under a frozen constraint, and therefore cut
off solutions. This caused a problem for the
`summon[(1 | Nothing) <:< 1]` comparison even once (1)
was fixed.
|
@abgruszecki It would be good to go over every occurrence of inFrozenGADT and reason whether or not it should be inFrozenConstraint as well. And vice versa. We seem to have too much independent development between the two. |
abgruszecki
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems in a comparison
If the LHS was
a.type | Nothing, atoms computationdid not correctly account for Nothing.
For other comparisons, the preliminary widen test was
not done under a frozen constraint, and therefore cut
off solutions. This caused a problem for the
summon[(1 | Nothing) <:< 1]comparison even once (1)was fixed.
Fixes #11003
But #10897 is not solved by this.