Keep named arguments during eta expansion #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this |
|
the |
| @@ -48,13 +48,11 @@ object EtaExpansion { | |||
| } | |||
|
|
|||
| /** Lift a function argument, stripping any NamedArg wrapper */ | |||
There was a problem hiding this comment.
I think the documentation needs to be updated, since we don't strip the NamedArg anymore.
There was a problem hiding this comment.
We do strip it, but then rewrap it around something else. I meant to do the change, but then decided it's too much busywork for too minor an improvement.
|
@DarkDimius Is there a stronger connection, e.g. via a symbol? |
|
No. Symbols of arguments of methods are only accessible inside the body of the method in Dotty. |
odersky
added a commit
that referenced
this pull request
Feb 19, 2016
Keep named arguments during eta expansion
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096. Review by @xeno-by