Refine criterion when we can skip an asSeenFrom #10982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jan 5, 2021
| @@ -1063,7 +1063,16 @@ object Denotations { | |||
| info.asSeenFrom(pre, owner), | |||
| if (symbol.is(Opaque) || this.prefix != NoPrefix) pre else this.prefix) | |||
|
|
|||
| if (!owner.membersNeedAsSeenFrom(pre) || symbol.is(NonMember)) this | |||
| // Tt could happen that we see the symbol with prefix `this` as a member a different class | |||
There was a problem hiding this comment.
Suggested change
| // Tt could happen that we see the symbol with prefix `this` as a member a different class | |
| // It could happen that we see the symbol with prefix `this` as a member of a different class |
There was a problem hiding this comment.
We have similar logic in Types.scala:
private def infoDependsOnPrefix(symd: SymDenotation, prefix: Type)(using Context): Boolean =
symd.maybeOwner.membersNeedAsSeenFrom(prefix) && !symd.is(NonMember)I'm wondering if it is worth creating a method to abstract the logic?
There was a problem hiding this comment.
Interesting observation! This looked promising at first, but in the end I found no way to improve over the status quo. The problem is that the code in Types only works for SymDenotations, whereas the more complicated logic in Denotations works also for SingleDenotations and it's difficult to break it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9352