Fix owner comparison when sorting eligible implicits #10977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the wrong symbols to compare, which in effect meant that we sorted eligible implicits wuthout taking owner subtyping into account. This way, we might consider canidates first that would then later be pruned by another sccesful candidate in a subclass, so the search tree would be larger. Fixes scala#10964
griggt
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the wrong symbols to compare, which in effect meant that
we sorted eligible implicits without taking owner subtyping into
account. This way, we might consider candidates first that would then
later be pruned by another successful candidate in a subclass, so the
search tree would be larger.
Fixes #10964