fix #10857: export from wildcard defs with same name as user declared ones #10949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
fix-10857
branch
from
f79059f to
a00e5b5
Compare
bishabosha
commented
Dec 29, 2020
| @main def Test = | ||
|
|
||
| println(Module.Red) | ||
| println(Module.valueOf("Red")) // error: value valueOf is not a member |
There was a problem hiding this comment.
e.g. here valueOf is still not exported from the enum because there is no user declared definition that matches that name
bishabosha
force-pushed
the
fix-10857
branch
from
a00e5b5 to
f822019
Compare
|
I have put for RC1 because if we accept this change, the API generated will change for the same source code |
odersky
requested changes
Jan 1, 2021
|
@odersky I have updated the documentation |
bishabosha
commented
Jan 7, 2021
| @@ -60,8 +60,7 @@ A member is _eligible_ if all of the following holds: | |||
| a base class of the class containing the export clause. | |||
| - it is accessible at the export clause, | |||
| - it is not a constructor, nor the (synthetic) class part of an object, | |||
| - it is a given instance (or an old-style `implicit` value) | |||
| if and only if the export is tagged with `given`. | |||
| - it is a given instance (declared with `given`) if and only if the export is from a _given selector_. | |||
There was a problem hiding this comment.
this change comes from observation that implicit forwarders are only generated from wildcard selectors and not given selectors
|
@odersky I have implemented the changes to documentation |
odersky
approved these changes
Jan 12, 2021
a wildcard export will first search for all public and non-synthetic members to add. Then once a valid member is found, that name is then used to search for all term or type members that use that name and are not given or private. As a consequence members like companion objects to case classes will be exported alongside a type alias to the case class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a wildcard export will first search for all public and
non-synthetic members to add. Then once a valid member
is found, that name is then used to search for all
term or type members that use that name and are not
given or private.
Status Quo for wildcard given exports.
As a consequence members like companion objects to
case classes will be exported alongside a type alias
to the case class
Fixes #10857