Change nested typer creation to allow creation of derived typers #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -508,7 +508,7 @@ class Namer { typer: Typer => | |||
| if (sym is Module) moduleValSig(sym) | |||
| else valOrDefDefSig(original, sym, Nil, Nil, identity)(localContext(sym).setNewScope) | |||
| case original: DefDef => | |||
| val typer1 = new Typer | |||
There was a problem hiding this comment.
@odersky, I'm curious why getting a signature of a DefDef requires creating a new Typer\Namer, while ValDefs and TypeDefs are fine using existing one?
|
LGTM |
odersky
added a commit
that referenced
this pull request
Feb 18, 2016
Change nested typer creation to allow creation of derived typers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the symbol completer runs, it may create a new Typer instance. But if the current typer is a derived typer the completer won't create an instance of the derived type. This change adds a method "newLikeThis" to the Typer class that can be overridden by derived typers.