Properly report clashes between classes and objects #10928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly report clashes between classes and objects defined in different source files. Fixes scala#9472
abgruszecki
reviewed
Dec 29, 2020
| */ | ||
| def checkNoModuleClash(sym: Symbol)(using Context): Unit = | ||
| if sym.effectiveOwner.is(Package) | ||
| && sym.owner.info.member(sym.name.moduleClassName).symbol.isAbsent() |
There was a problem hiding this comment.
I don't understand the logic here. It seems that we always call checkNoModuleClash with a module symbol. If that's the case, then shouldn't this symbol always be non-absent? Or is it that this symbol was marked absent when we added the clashing class's symbol as a member?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly report clashes between classes and objects defined in
different source files.
Fixes #9472