Fix #10127: Don't try to get tags after error #10851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tags may be unavailablle due to the error.
liufengyun
approved these changes
Dec 18, 2020
| val tagRef = getQuoteTypeTags.getTagRef(splice.qualifier.tpe.asInstanceOf[TermRef]) | ||
| ref(tagRef).withSpan(splice.span) | ||
| if ctx.reporter.hasErrors then | ||
| splice |
There was a problem hiding this comment.
Do we need to transform the body for this case?
There was a problem hiding this comment.
We don't need to. That tree will not be used after the error. We could return body1.select(...).with span(...) but it might just complicate the code for no practical reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags may be unavailablle due to the error.