-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix support for project with no sources #10843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for project with no sources #10843
Conversation
fa1e8a5
to
b1e0da8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also bump sbt-dotty to 0.5.1 in https://github.com/lampepfl/dotty/blob/75365ead70a2ca3a39b0b351c0e80889c5e48ab3/project/Build.scala#L59, then I can do a release by pushing a tag.
Do I understand correctly that the |
32f1e42
to
402dbac
Compare
The problem is that we need to adda fake scala file to workaround check in sbt that does not run doc if there is no scala file in Community build does not catch this problem since either projects has no publish set for docs or no sourcse in |
@smarter version is bumped |
bump sbtDotty version to 0.5.1
402dbac
to
c28b3a8
Compare
Ok, my bad, let me be more precise, I'm asking what exactly is testing that the issue will not reoccur. The newly-added test project has a single source in |
Also, it seems that |
Yes. You try youself that before the fix |
[test_sbt]