Default to Scala3doc #10762
Merged
Default to Scala3doc #10762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Dec 12, 2020
smarter
reviewed
Dec 12, 2020
| @@ -362,7 +362,7 @@ object DottyPlugin extends AutoPlugin { | |||
|
|
|||
| // Configuration for the doctool | |||
| resolvers ++= (if(!useScala3doc.value) Nil else Seq(Resolver.jcenterRepo)), | |||
| useScala3doc := false, | |||
| useScala3doc := VersionNumber(scalaVersion.value).matchesSemVer(SemanticSelector(">=3.0.0-M3")), | |||
There was a problem hiding this comment.
Note that I haven't checked if the current version number is considered >= 3.0.0-M3
|
Alright, hold off on the reviews, I'll work on this tomorrow. We also need to check if we still can publish Dotty itself locally, I guess. |
abgruszecki
force-pushed
the
default-to-scala3doc
branch
from
7c0946b to
0f2922b
Compare
abgruszecki
force-pushed
the
default-to-scala3doc
branch
from
0f2922b to
0fd03ff
Compare
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 13, 2020
Because we're building sbt-dotty using sbt 1.4, we cannot guarantee that it works with older sbt versions (and in fact it doesn't), since this is a compatibility, we also bump the version number of sbt-dotty. Waiting for scala#10762 to be merged before releasing sbt-dotty 0.5.0.
romanowski
approved these changes
Dec 13, 2020
smarter
approved these changes
Dec 13, 2020
| useScala3doc := false, | ||
| useScala3doc := { | ||
| val v = scalaVersion.value | ||
| v.startsWith("3.0.0") && !v.startsWith("3.0.0-M1") && !v.startsWith("3.0.0-M2") |
There was a problem hiding this comment.
More future-proof:
Suggested change
| v.startsWith("3.0.0") && !v.startsWith("3.0.0-M1") && !v.startsWith("3.0.0-M2") | |
| v.startsWith("3") && !v.startsWith("3.0.0-M1") && !v.startsWith("3.0.0-M2") |
There was a problem hiding this comment.
This setting is going to disappear with 3.0.0, there's no need for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to
useScala3doc := true.We should leave it there for now I guess for compat reasons.