partest: run tests with -Xms64M -Xmx1024M instead of JVM defaults #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/run-tests-memory
branch
from
9988c09 to
ef60a94
Compare
This is the same settings that scalac uses, this should help use avoid using too much memory (the default on 64 bits Linux seems to be -Xms248M -Xmx3938M).
smarter
force-pushed
the
fix/run-tests-memory
branch
from
ef60a94 to
d57fd8b
Compare
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Feb 12, 2016
partest: run tests with -Xms64M -Xmx1024M instead of JVM defaults
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 1, 2016
This should be safe now that run tests do not take so much memory anymore (cf scala#1033 and scala#1076). It would be even better if we could figure out why we're using so much memory, but that's less important than avoiding spurious test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same settings that scalac uses, this should help use avoid
using too much memory (the default on 64 bits Linux seems to be
-Xms248M -Xmx3938M).
Review by @DarkDimius