Use tuple or boolean types for extractors that will always match #10738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Dec 10, 2020
| @@ -156,7 +156,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler | |||
| withDefaultPos(tpd.Import(expr, selectors)) | |||
| def copy(original: Tree)(expr: Term, selectors: List[Selector]): Import = | |||
| tpd.cpy.Import(original)(expr, selectors) | |||
| def unapply(tree: Import): Option[(Term, List[Selector])] = | |||
| def unapply(tree: Import): Some[(Term, List[Selector])] = | |||
| Some((tree.expr, tree.selectors)) | |||
There was a problem hiding this comment.
The return type can be just (Term, List[Selector]), it is also irrefutable -- product matches are always irrefutable. The same for the other changes.
There was a problem hiding this comment.
I was just investigating that possibility :)
I will update it.
There was a problem hiding this comment.
This also caught some extra bugs
bishabosha
reviewed
Dec 10, 2020
For these, it is the `TypeTest` that determines if the match will succeed.
nicolasstucki
force-pushed
the
use-precise-return-types-for-unapplies
branch
from
1e386ab to
90ac3cb
Compare
nicolasstucki
changed the title
Some for extractors that will always match
liufengyun
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these, it is the
TypeTestthat determines if the match will succeed.Constantdo not follow this design and hence keepOption