Skip to content

Community build: split into 3 concurrent jobs #10731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Dec 10, 2020

No description provided.

@griggt griggt force-pushed the cb-more-partitions branch 3 times, most recently from 8491e5c to 032d1da Compare December 15, 2020 04:50
@griggt griggt force-pushed the cb-more-partitions branch from 032d1da to 6bde48b Compare January 12, 2021 00:02
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarter
Copy link
Member

smarter commented Mar 18, 2021

If you're interested in reviving this PR (was there anything missing that led to it staying unmerged?), now might be a good time as the community build has grown quite a bit.

@griggt
Copy link
Contributor Author

griggt commented Mar 18, 2021

At the time, I didn't think it was a big enough win (~45 vs. 60 minutes at the cost of an extra runner)

I'll have a look at updating it today.

@griggt griggt force-pushed the cb-more-partitions branch from 6bde48b to fe67ac3 Compare March 19, 2021 02:48
@griggt griggt force-pushed the cb-more-partitions branch from fe67ac3 to 997fe75 Compare March 19, 2021 05:50
@griggt
Copy link
Contributor Author

griggt commented Mar 19, 2021

Latest community build running times (minutes):

This PR 44 / 46 / 44
Nightly build72 / 59

@griggt griggt marked this pull request as ready for review March 19, 2021 06:54
@griggt griggt requested review from smarter and prolativ March 19, 2021 06:55
@griggt griggt removed their assignment Mar 19, 2021
@smarter smarter merged commit 1ba9185 into scala:master Mar 19, 2021
@griggt griggt deleted the cb-more-partitions branch March 19, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants