Slightly Improved Varargs Extractor #10729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CiaraOBrien could you add a test case with the code you have that used to fail. This way we can ensure we will not have a regression on this improvement in the future. |
|
The implementation looks good |
|
Sorry, I totally missed this. I have no recollection of what the specific situation was that this solved, but I'll see if I can break the project in question by finding-and-replacing |
nicolasstucki
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to
scala.quoted.Varargs.unapplyto make it apply in more circumstances when inlining is involved, as (as far as I can tell/recall) sometimes varargs end up being encoded asTyped(Inlined(EmptyTree, List(), Repeated(elems, _)), _)notTyped(Repeated(elems, _), _)orInlined(EmptyTree, List(), Typed(Repeated(elems, _), _))in corner cases, which means the old implementation fails to match in a confusing manner. This improves things substantially in my wacky heavily-inlining macro expansions, and I'm pretty sure it doesn't break anything.