Skip to content

Fix tests on windows #10719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2020
Merged

Fix tests on windows #10719

merged 2 commits into from
Dec 9, 2020

Conversation

romanowski
Copy link
Contributor

[test_windows_full]

@romanowski romanowski mentioned this pull request Dec 9, 2020
Closed
@smarter
Add comamnds to force or skip the Windows CI
4eebd05 
The commands are [test_windows_full] and [skip test_windows_fast]
@romanowski
Copy link
Contributor Author

Thanks @smarter for changes in GH actions. Windows tests are green I think this is good merge.

abgruszecki
abgruszecki approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think we need to wait for the community build.

@abgruszecki abgruszecki merged commit 265a279 into scala:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgruszecki abgruszecki abgruszecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanowski @abgruszecki @smarter