Skip to content

Do not render empty packages in package list #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Do not render empty packages in package list #10688

merged 1 commit into from
Dec 7, 2020

Conversation

romanowski
Copy link
Contributor

No description provided.

@romanowski romanowski mentioned this pull request Dec 7, 2020
Closed
abgruszecki
abgruszecki reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also get rid of the package in the index?

@romanowski
Copy link
Contributor Author

We filter them out in NavigationCreator. When I was changing it I forgot about list of nested packages.

@abgruszecki abgruszecki merged commit e5e27a4 into scala:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgruszecki abgruszecki abgruszecki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanowski @abgruszecki