-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Normalize slashes in paths in TASTy binaries #10678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize slashes in paths in TASTy binaries #10678
Conversation
@liufengyun Asking since you were involved with similar PRs, also involving Windows. It seems like |
@bishabosha since you worked around TASTy reader, are there any tests for it that get ran on Windows? |
@abgruszecki One way i normalised paths was in ExtractSemanticDB where the path is converted to javas URI |
@nicolasstucki Should we mention somewhere that the paths in tasty binaries always use forward slashes? |
Documentation for this is a good idea.
|
Yes, |
@nicolasstucki where should we modify |
And yes, I'll also modify the Quotes API. |
974afe5
to
b6f38c8
Compare
b30887e
to
1bb5fd4
Compare
1bb5fd4
to
0c17ff4
Compare
[test_windows_full]