Fix #997 #1066
Merged
Fix #997 #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
| val errors1 = | ||
| if (tp.symbol.is(Private) && | ||
| !accessBoundary(sym).isContainedIn(tp.symbol.owner)) { | ||
| (d"non-private $sym refers to private ${tp.symbol}\n in its type signature ${sym.info}", tree.pos) :: errors |
There was a problem hiding this comment.
Why not just call ctx.errorOrMigrationWarning here?
There was a problem hiding this comment.
Because we might end up not issuing the error if a parent is a TypeAlias.
|
Ready to merge? |
|
LGTM |
Previously, some definitions were too public, others too private.
First version. Fixes scala#997.
Also: include a test that private aliases are transparent.
|
Rebased to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that private references do not leak. Review by @DarkDimius