Skip to content

Update reflect.Symbol position API #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki changed the title Update reflect.Symbol API Update reflect.Symbol position API Dec 4, 2020
@nicolasstucki nicolasstucki force-pushed the update-reflect-symbol-api branch 2 times, most recently from be1e473 to ad61c23 Compare December 6, 2020 11:03
* `Symbol.pos` return an `Option[Position]`
* Remove `Position.exists`
@nicolasstucki nicolasstucki force-pushed the update-reflect-symbol-api branch from ad61c23 to bde343c Compare December 6, 2020 20:16
@nicolasstucki nicolasstucki marked this pull request as ready for review December 7, 2020 07:11
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 121ced4 into scala:master Dec 7, 2020
@nicolasstucki nicolasstucki deleted the update-reflect-symbol-api branch December 7, 2020 08:36
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants