Force the initialization of throwMethod in Definitions #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM after tests pass |
|
Review by @odersky , @DarkDimius |
|
/rebuild |
1 similar comment
|
/rebuild |
| /** Lists core methods that don't have underlying bytecode, but are synthesized on-the-fly in every reflection universe */ | ||
| lazy val syntheticCoreMethods = AnyMethods ++ ObjectMethods ++ List(String_+) | ||
| /** Lists core methods that don't have underlying bytecode, but are synthesized on-the-fly in every reflection universe */ | ||
| lazy val syntheticCoreMethods = AnyMethods ++ ObjectMethods ++ List(String_+, throwMethod) |
There was a problem hiding this comment.
indentation here was intentional: member definitions are indented with 2 more spaces compared to class definitions.
VladimirNik
force-pushed
the
throwMethodInit
branch
from
0d24df6 to
6560f38
Compare
odersky
added a commit
that referenced
this pull request
Feb 5, 2016
Force the initialization of throwMethod in Definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix the problem with unpickling of throw expression from TASTY representation.