Fix #10573: Devirtualize member selection when matching #10576
Conversation
|
test performance with #quotes please |
|
performance test scheduled: 4 job(s) in queue, 1 running. |
|
|
||
| devirtualizedScrutinee == pattern | ||
| || summon[Env].get(devirtualizedScrutinee).contains(pattern) | ||
| || devirtualizedScrutinee.allOverriddenSymbols.contains(pattern) |
There was a problem hiding this comment.
The documentation of the method needs to be updated. The following code might be faster:
scrutinee.overridingSymbol(pattern.owner) == pattern
|| pattern.overridingSymbol(scrutinee.owner) == scrutineeThere was a problem hiding this comment.
Will try that. The current performance is unaccepable.
There was a problem hiding this comment.
overridingSymbol worked, but not there.
There was a problem hiding this comment.
If the check is whether the two symbols override each other, can we simply replace the body of the method with the following:
scrutinee.overridingSymbol(pattern.owner) == pattern
|| pattern.overridingSymbol(scrutinee.owner) == scrutineeThere was a problem hiding this comment.
That version had some false positives involving modules.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/10576/ to see the changes. Benchmarks is based on merging with master (90f44d4) |
nicolasstucki
force-pushed
the
fix-#10573
branch
from
7b15934 to
96d5073
Compare
|
test performance with #quotes please |
|
performance test scheduled: 6 job(s) in queue, 0 running. |
|
test performance with #quotes please |
|
performance test scheduled: 11 job(s) in queue, 0 running. |
|
@liufengyun the benchmarks might be stuck |
|
Yes, I stopped it, I am investigating the latest failures. |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/10576/ to see the changes. Benchmarks is based on merging with master (bbdbdf2) |
|
Now performance is fine |
No description provided.