-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Hirarchy diagram tests for scala3doc #10554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use 2 spaces to indent, not 4.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Seq( | ||
"Object" -> "Any", | ||
"A2[T]" -> "Object", | ||
"B2" -> "A2[T]", // These are not actually true, becuase we lose information about hierarchy in subtypes and their possible mapping to supertypes other that that type itself, e. g. linking to `Object` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not make sense for me that this commet is here. Also We could assign common parts of the graph to value so we do not duplicated it (since we are sorting it at the end anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is valid since we have no bigger depth of graph than 1 even though it is not true. Ripping common parts in my opinion it tedious job because there is not so many parts that are common (sometimes it differs on applied type). I will change to Set
though to eliminate sorting
810ddf7
to
9b7f7ab
Compare
No description provided.