Hirarchy diagram tests for scala3doc #10554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Dec 2, 2020
romanowski
reviewed
Dec 2, 2020
| Seq( | ||
| "Object" -> "Any", | ||
| "A2[T]" -> "Object", | ||
| "B2" -> "A2[T]", // These are not actually true, becuase we lose information about hierarchy in subtypes and their possible mapping to supertypes other that that type itself, e. g. linking to `Object` |
There was a problem hiding this comment.
It does not make sense for me that this commet is here. Also We could assign common parts of the graph to value so we do not duplicated it (since we are sorting it at the end anyway)
There was a problem hiding this comment.
This comment is valid since we have no bigger depth of graph than 1 even though it is not true. Ripping common parts in my opinion it tedious job because there is not so many parts that are common (sometimes it differs on applied type). I will change to Set though to eliminate sorting
romanowski
approved these changes
Dec 7, 2020
BarkingBad
force-pushed
the
diagram-tests
branch
from
810ddf7 to
9b7f7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.