Skip to content

Fix #10357: Add MATCHCASEtype tag to Tasty #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix #10357: Add MATCHCASEtype tag to Tasty #10362

merged 1 commit into from
Nov 18, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 17, 2020

We thus avoid references to a "magic" scala.internal.MatchCase class.

@odersky odersky changed the title Add MATCHCASEtype tag to Tasty Fix #10357: Add MATCHCASEtype tag to Tasty Nov 17, 2020
@odersky odersky mentioned this pull request Nov 17, 2020
Closed
smarter
smarter requested changes Nov 17, 2020
View reviewed changes
tasty/src/dotty/tools/tasty/TastyFormat.scala
@@ -676,6 +678,7 @@ object TastyFormat {
case TYPELAMBDAtype => "TYPELAMBDAtype"
case LAMBDAtpt => "LAMBDAtpt"
case MATCHtype => "MATCHtype"
case MATCHCASEtype => "MATCHCASEtype"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TastyPrinter will need a case too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe not, I see we don't need cases for all type nodes in the printer.

smarter
smarter approved these changes Nov 17, 2020
View reviewed changes
tasty/src/dotty/tools/tasty/TastyFormat.scala
@@ -676,6 +678,7 @@ object TastyFormat {
case TYPELAMBDAtype => "TYPELAMBDAtype"
case LAMBDAtpt => "LAMBDAtpt"
case MATCHtype => "MATCHtype"
case MATCHCASEtype => "MATCHCASEtype"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe not, I see we don't need cases for all type nodes in the printer.

@romanowski
Copy link
Contributor

The failure in scala3doc comes from one of the projects what we use to build documentation for Scala 3 defined here: https://github.com/lampepfl/dotty/blob/master/project/Build.scala#L1499-L1503

@smarter
Copy link
Member

smarter commented Nov 17, 2020

Thanks @romanowski, looks like tasty-core should be tasty-core-bootstrapped and scala3-library should be scala3-library-bootstrapped to get tasty files compiled with the current compiler instead of the reference compiler (nothing needs to be done for scala3-interfaces since it's java-only)

@romanowski romanowski mentioned this pull request Nov 17, 2020
Merged
@romanowski
Copy link
Contributor

@smarter I wonder if we should not include a path or any other way to quickly detect which .tasty file is causing problem in case of anyone will face similar issue in the future

@odersky @abgruszecki
Add MATCHCASEtype tag to Tasty
90cdf18 
We thus avoid references to a "magic" scala.internal.MatchCase class.
@abgruszecki abgruszecki merged commit 7dc0107 into scala:master Nov 18, 2020
@abgruszecki abgruszecki deleted the fix-tasty branch November 18, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@abgruszecki abgruszecki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odersky @romanowski @smarter @abgruszecki