Skip to content

Add CLA workflow #10344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Add CLA workflow #10344

merged 1 commit into from
Nov 16, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki force-pushed the add-CLA-workflow branch 4 times, most recently from dbcd72d to 1077b2f Compare November 16, 2020 15:56
@nicolasstucki
Copy link
Contributor Author

I have no idea where the older version of the CLA check is setup. We still need to disable that one. (odd CLA, new Scala CLA)

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I couldn't find the old one either.

@sjrd
Copy link
Member

sjrd commented Nov 16, 2020

Just make sure that check-cla.sh has the executable bit set in git. I don't know how to check that on the GitHub UI. Otherwise LGTM.

@smarter
Copy link
Member

smarter commented Nov 16, 2020

I tweaked the settings so the original CLA check isn't required anymore to merge something, I'll try disabling the scala-webapps.epfl.ch webhook to see if that also removes it from the list of checks we get.
EDIT: that seems to have worked

@smarter smarter merged commit 088398b into scala:master Nov 16, 2020
@smarter smarter deleted the add-CLA-workflow branch November 16, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants