Fix #9790: Update indentation spec to match observed behavior #10331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the clause
2. An `<outdent>` is inserted at a line break, if
- ...
- the last token on the previous line is not one of the following tokens
which indicate that the previous statement continues:
```
then else do catch finally yield match
```
I tried to do without the added clause but lots of tests break. To verify, set
Tokens.statCtdTokens to BitSet() and observe the breakage.
tgodzik
approved these changes
Nov 16, 2020
|
@tgodzik Thanks! And sorry for waiting so long to address this... I am still in catchup mode with issues. |
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 18, 2020
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the clause
An
<outdent>is inserted at a line break, ifwhich indicate that the previous statement continues:
I tried to do without the added clause but lots of tests break. To verify, set
Tokens.statCtdTokens to BitSet() and observe the breakage.