Change early typeparams, take 3 #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're getting a lot of OutOfMemoryException when the maximum size is 1 GB, but we cannot increase it too much without using up all the memory available on the Jenkins instances, let's see if 1.1 GB is enough. Also stop using a custom -Xss, the default of 1 MB should be good enough.
smarter
force-pushed
the
change-early-typeparams3
branch
from
57ed489 to
5042ba3
Compare
I observed in a local partest a file with was a java.io.Path, not an SFile. They should be treated like SFiles. Not clear why this came up. The file in question (partest-generated/pos/Patterns_v1.scala) looked just like all the others that were read as SFiles.
There was no reason in the first case to cache them, as their equality is reference identity. Maybe this fixes the OOM errors we encounter.
Need to also look info refined types. Need to handle case where we hit a NoCompleter again. Fixes scala#974 and makes MutableSortedSetFactory in stdlib compile.
Type params should be computed before computing the whole info of a type. Without the patch we get a cyclic reference in the compileMixed test. Note that compileIndexedSeq does not pass with this commit (it passed before), this is fixed in the next commit.
This makes compileIndexedSeq pass again.
smarter
force-pushed
the
change-early-typeparams3
branch
from
5042ba3 to
17dcd7c
Compare
odersky
added a commit
that referenced
this pull request
Jan 17, 2016
Change early typeparams, take 3
|
It's great that this got merged but there's still one unadressed comment from the previous version: https://github.com/lampepfl/dotty/pull/1028/files#r49922624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should supersede #1028 and is based on top of #1030
Review by @odersky