Skip to content

page navigation loads as soon as possible #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

page navigation loads as soon as possible #10298

merged 1 commit into from
Nov 13, 2020

Conversation

romanowski
Copy link
Contributor

No description provided.

@romanowski
Copy link
Contributor Author

cc @MarcinAman @kamildoleglo

TheElectronWill
TheElectronWill approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@TheElectronWill TheElectronWill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
As I said on Slack, I believe that more optimizations should be possible with regards to the way scripts are loaded. It would be interesting to try to make the navigation loading start before some less important scripts.

@romanowski romanowski merged commit b17180f into scala:master Nov 13, 2020
@MarcinAman
Copy link

LGTM!
As I said on Slack, I believe that more optimizations should be possible with regards to the way scripts are loaded. It would be interesting to try to make the navigation loading start before some less important scripts.

If you have some ideas on how to improve our scripts please let me know, i'd also like to change it in dokka itself :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheElectronWill TheElectronWill TheElectronWill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanowski @MarcinAman @TheElectronWill