Skip to content

Align quoted.Type with reflect.TypeRepr and reflect.TypeTree #10283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Align quoted.Type with reflect.TypeRepr and reflect.TypeTree #10283

merged 1 commit into from
Nov 12, 2020

Conversation

nicolasstucki
Copy link
Contributor

  • Rename Type.apply to Type.of to have the same names as in TypeRepr and TypeTree
def f[T: Type](using QuoteContext) = {
  val quotedType = Type.of[T]
  val typeRepr = TypeRepr.of[T]
  val typeTree = TypeTree.of[T]
  ....
}

@nicolasstucki nicolasstucki force-pushed the rename-type-apply-to-type-of branch 4 times, most recently from 7a2fb99 to 2713a7e Compare November 12, 2020 08:29
@nicolasstucki nicolasstucki marked this pull request as ready for review November 12, 2020 08:29
@nicolasstucki nicolasstucki force-pushed the rename-type-apply-to-type-of branch from 36daa85 to 2713a7e Compare November 12, 2020 09:09
liufengyun
liufengyun approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Align quoted.Type with reflect.TypeRepr and reflect.TypeTree
bd19b84 
* Rename `Type.apply` to `Type.of` to have the same names as in `TypeRepr` and `TypeTree`
@nicolasstucki nicolasstucki force-pushed the rename-type-apply-to-type-of branch from 2713a7e to bd19b84 Compare November 12, 2020 09:25
@nicolasstucki nicolasstucki merged commit 1180aba into scala:master Nov 12, 2020
@nicolasstucki nicolasstucki deleted the rename-type-apply-to-type-of branch November 12, 2020 12:22
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan