Skip to content

Use Tree.asExpr #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Use Tree.asExpr #10278

merged 1 commit into from
Nov 12, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 11, 2020 •
edited
Loading

Replaced seal with asExpr. Most uses of seal were removed when we removed cast (.seal.cast[T] -> asExprOf[T]).

Also updated dotty-cps-async to not use cast.

@nicolasstucki nicolasstucki marked this pull request as ready for review November 11, 2020 10:58
liufengyun
liufengyun approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit a6d9b00 into scala:master Nov 12, 2020
@nicolasstucki nicolasstucki deleted the use-asExpr branch November 12, 2020 09:16
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
prio:blocker
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan