Improve migration message for Scala 2 procedures #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not correct to just add `=` you also need to specify the return type to be `Unit` otherwise things may not work as expected, this is especially important for a `main` method.
smarter
force-pushed
the
fix/procedure-migration
branch
from
b7411a3 to
3b5c70b
Compare
|
Not sure about this. |
|
I don't think there are many It's fine if users want to remove the |
|
OK, you have convinced me. LGTM. |
odersky
added a commit
that referenced
this pull request
Jan 17, 2016
Improve migration message for Scala 2 procedures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not correct to just add
=you also need to specify the returntype to be
Unitotherwise things may not work as expected, this isespecially important for a
mainmethod.Review by @odersky