Skip to content

Fix #10098: Handle inheritance for implicitNotFound annotation #10190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

prolativ
Copy link
Contributor

@prolativ prolativ commented Nov 5, 2020

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@prolativ
Copy link
Contributor Author

prolativ commented Nov 5, 2020

This PR fixes the issue by making the behaviour like in scala 2.13. However there are some corner cases handled in neither version e.g.

trait Foo
trait Bar extends (Foo @annotation.implicitNotFound("Custom message"))
object Test {
  implicitly[Bar]
}

Should the custom message be displayed here?

@smarter
Copy link
Member

smarter commented Nov 5, 2020

No, that's fine, the documentation of https://www.scala-lang.org/api/2.13.3/scala/annotation/implicitNotFound.html states where the annotation has an effect and that doesn't include parent clauses.

@prolativ
Copy link
Contributor Author

prolativ commented Nov 6, 2020

PR ready for merge then

@smarter smarter merged commit d329c13 into scala:master Nov 6, 2020
@prolativ prolativ deleted the implicitNotFound-inheritance branch November 6, 2020 12:24
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants