Fix #10177: Test @JSType in isJSType instead of using time travel.
#10188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ravel. The time travel in `isJSType` was causing an issue when used from `ExplicitJSClasses`. It would somehow interfere with `ExplicitOuter`, which would then generate an outer pointer twice. We now test the presence of the `@JSType` annotation, which is also what Scala 2 does. Historically we used the time travel because we had not implemented `PrepJSInterop`, which is responsible for adding the `@JSType` annotations in the first place.
dottybot
reviewed
Nov 5, 2020
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time travel in
isJSTypewas causing an issue when used fromExplicitJSClasses. It would somehow interfere withExplicitOuter, which would then generate an outer pointer twice.We now test the presence of the
@JSTypeannotation, which is also what Scala 2 does. Historically we used the time travel because we had not implementedPrepJSInterop, which is responsible for adding the@JSTypeannotations in the first place.