Drop extension_ prefix for extension methods #10128
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
odersky
force-pushed
the
drop-extension-mangling
branch
from
4b16a45 to
8029c2c
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/10128/ to see the changes. Benchmarks is based on merging with master (1ab76c1) |
|
I believe performance will improve once we get rid of the double tests that have to account for old as well as new naming schemes for extension methods. We can get rid of that once we are sure that all dependencies are compiled with the new version. |
Allow only qualified references `p.f` to an extension method `f`.
For the moment will still support extension_name references to extension methods in order to work with non-bootstrapped libraries. But we do not generate these names anymore.
Otherwise the extension method `reporting` clashes with the `reporting` package.
Needed to make sure that rawParamss is set
Now that extension names are the same as normal names, we got several ambiguos imports
Partial revert of the tests that had to be changed to satisfy the restriction which is now dropped again.
This reverts commit 905fb14.
Because of the trailing blanks issue in the docs it's basically impossible to do a reliable rebase.
odersky
force-pushed
the
drop-extension-mangling
branch
from
a1560ad to
e144d9b
Compare
|
@bishabosha It would be good to get this in quickly. It's been an absolute pain to rebase. Thanks! |
Co-authored-by: Jamie Thompson <[email protected]>
Follow scheme described in https://contributors.scala-lang.org/t/two-proposed-changes-for-extension-methods/4589/25?u=odersky