Skip to content

Rename Reflection.Type to TypeRepr #10086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

nicolasstucki
Copy link
Contributor

Renaming this will fix all ambiguities between quoted.Type and reflect.Type that are imported in the same scope.
This happened every time we imported reflection. For example in

import scala.quoted._ // import scala.quoted.Type
def f(using QuoteContext): Expr[Unit] = {
  import qctx.reflect._ // used to shadow scala.quoted.Type with qctx.reflect.Type
  def f[T:Type] = ... // error
  ...
}

After this change, the code above works.

Renaming this will fix all ambigouities between `quoted.Type` and `reflect.Type` that are imported in the same scope.
@nicolasstucki nicolasstucki marked this pull request as ready for review October 26, 2020 15:27
@smarter smarter added this to the 3.0.0-M1 milestone Oct 26, 2020
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor: TypeRep vs TypeRepr, I find the former shorter, but not a big deal.

@nicolasstucki nicolasstucki merged commit ac4e29d into scala:master Oct 26, 2020
@nicolasstucki nicolasstucki deleted the rename-refllect-type branch October 26, 2020 16:41
@Kordyjan Kordyjan modified the milestones: 3.0.0-M1, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants