Skip to content

Use 3.0.0-M1 nightly as a reference compiler #10058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@smarter
Copy link
Member

smarter commented Oct 21, 2020

Error: Bad symbolic reference. A signature
Error: refers to Enum/T in package scala.reflect which is not available.

https://github.com/lampepfl/dotty/blob/master/library/src-bootstrapped/scala/reflect/Enum.scala and https://github.com/lampepfl/dotty/blob/master/library/src-bootstrapped/scala/Enum.scala need to be moved to library/src, https://github.com/lampepfl/dotty/blob/master/library/src-non-bootstrapped/scala/Enum.scala needs to be deleted (the same might be true for the other files in src-bootstrapped and src-non-bootstrapped, I don't know if there's some reasons they'd need to stay as is /cc @nicolasstucki)

@smarter
Copy link
Member

smarter commented Oct 21, 2020

Also we should bring back 099074c which was blocked on having a new reference compiler.

@nicolasstucki
Copy link
Contributor

I don't see a reason why we should keep Enum.scala split with this update. Moving it to library/src is the right thin to do in this case.

@bishabosha bishabosha force-pushed the reference-3m1nightly branch from 56ed1e5 to d1c2e46 Compare October 22, 2020 09:37
@bishabosha
Copy link
Member

I moved the files and rebased

@anatoliykmetyuk
Copy link
Contributor Author

Thanks a lot @bishabosha!

@smarter
Copy link
Member

smarter commented Oct 22, 2020

@nicolasstucki My question was about the other files in src-non-bootstrapped and src-bootstrapped which are all macro-related stuff, should they be moved too?

anatoliykmetyuk and others added 2 commits October 22, 2020 14:15
Co-authored-by: Anatolii Kmetiuk <[email protected]>
Co-authored-by: Jamie Thompson <[email protected]>
Was superceded by `given` in scala#9949.
@smarter smarter force-pushed the reference-3m1nightly branch from fab240e to 3a52817 Compare October 22, 2020 12:16
@nicolasstucki
Copy link
Contributor

No, the macro related stuff should stay

@bishabosha
Copy link
Member

so can this be merged?

@nicolasstucki nicolasstucki merged commit 2d28962 into scala:master Oct 22, 2020
@nicolasstucki nicolasstucki deleted the reference-3m1nightly branch October 22, 2020 15:22
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants