Ycheck that scala.Array is erazed to either Object or JavaArrayType. #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should either be erased to j.l.Object or replaced by JavaArrayType.
…ing/dotty into ycheck-erasure-arrays
Array is still allowed after erasure when compiling Array.scala.
|
@DarkDimius If you give a LGTM we can merge this one. |
|
@DarkDimius you still need to review my last commits, then we can merge. |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Jan 4, 2016
Ycheck that scala.Array is erazed to either Object or JavaArrayType.
odersky
referenced
this pull request
in dotty-staging/dotty
Feb 18, 2016
Previously, the implicit definitions were always ambiguous, which is surely not right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected to fail and demonstrate a bug in erasure.