Skip to content

Improve error messages for -from-tasty compilation #10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

nicolasstucki
Copy link
Contributor

There is no point trying to load the tasty file after we have emitted the error.
Loading it only end up in a second error that shadows the root of the problem.

Also improve readabllility of the error message.

@nicolasstucki nicolasstucki self-assigned this Oct 15, 2020
There is no point trying to load the tasty file after we have emitted the error.
Loading it only end up in a second error that shadows the root of the problem.

Also improve readabllility of the error message.
@nicolasstucki nicolasstucki marked this pull request as ready for review October 19, 2020 07:26
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 8994a84 into scala:master Oct 19, 2020
@liufengyun liufengyun deleted the avoid-double-errors branch October 19, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants