Skip to content

make values and valueOf only available on enumerations #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2020
Merged

make values and valueOf only available on enumerations #10002

merged 4 commits into from
Oct 15, 2020

Conversation

bishabosha
Copy link
Member

these methods will only be available when an enum defines purely value cases

@bishabosha bishabosha requested review from smarter and sjrd October 14, 2020 13:35
@bishabosha bishabosha force-pushed the topic/enum-values-only-when-enumeration branch 2 times, most recently from 805ec33 to 8125006 Compare October 14, 2020 13:37
sjrd
sjrd reviewed Oct 14, 2020
View reviewed changes
@bishabosha bishabosha requested a review from sjrd October 14, 2020 15:19
@bishabosha
Copy link
Member Author

bishabosha commented Oct 14, 2020 •
edited
Loading

in this state, the signatures exist but will always fail at compile time if called - so semanticdb and tasty will be generated

@bishabosha bishabosha force-pushed the topic/enum-values-only-when-enumeration branch from 9ffbd1c to ca14396 Compare October 15, 2020 10:31
@bishabosha
Copy link
Member Author

bishabosha commented Oct 15, 2020 •
edited
Loading

rebased, i guess one issue/benefit of this thing is now someone can't define their own values/valueOf to replace the ones that will not be auto generated - so i should probably implement a custom missing member error

@bishabosha
Copy link
Member Author

bishabosha commented Oct 15, 2020 •
edited
Loading

so i should probably implement a custom missing member error

this makes it more complex because now you have to choose whether to intercept the "did you mean value" (rather than values) message, or the import suggestions message

@bishabosha
Copy link
Member Author

error in community build:

[warn] 
[warn] 	Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn] 		org.xerial.sbt:sbt-pack:0.13 (sbtVersion=1.0, scalaVersion=2.12)
[warn] 
[warn] 	Note: Unresolved dependencies path:
Error:  sbt.librarymanagement.ResolveException: Error downloading org.xerial.sbt:sbt-pack;sbtVersion=1.0;scalaVersion=2.12:0.Error:    Not found
Error:    Not found
Error:    download error: Caught java.net.UnknownHostException: repo1.maven.org (repo1.maven.org) while downloading https://repo1.maven.org/maven2/org/xerial/sbt/sbt-pack_2.12_1.0/0.13/sbt-pack-0.13.pom
Error:    not found: /root/.ivy2/local/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/sbt-plugin-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/central/org/xerial/sbt/sbt-pack_2.12_1.0/0.13/sbt-pack-0.13.pom
Error:    not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://repo.typesafe.com/typesafe/ivy-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:  Error downloading org.scala-js:scalajs-sbt-test-adapter_2.12:1.2.Error:    Not found
Error:    Not found
Error:    download error: Caught java.net.UnknownHostException: repo1.maven.org (repo1.maven.org) while downloading https://repo1.maven.org/maven2/org/scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/scalajs-sbt-test-adapter_2.12-1.2.0.pom
Error:    not found: /root/.ivy2/local/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/sbt-plugin-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/central/org/scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/scalajs-sbt-test-adapter_2.12-1.2.0.pom
Error:    not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:  	at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:249)
Error:  	at lmcoursier.CoursierDependencyResolution.$anonfun$update$35(CoursierDependencyResolution.scala:218)
Error:  	at scala.util.Either$LeftProjection.map(Either.scala:573)
Error:  	at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:218)
Error:  	at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
Error:  	at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:52)
Error:  	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:102)
Error:  	at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:69)
Error:  	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:115)
Error:  	at scala.util.control.Exception$Catch.apply(Exception.scala:228)
Error:  	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:115)
Error:  	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:96)
Error:  	at sbt.util.Tracked$.$anonfun$inputChanged$1(Tracked.scala:150)
Error:  	at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:129)
Error:  	at sbt.Classpaths$.$anonfun$updateTask0$5(Defaults.scala:2950)
Error:  	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
Error:  	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
Error:  	at sbt.std.Transform$$anon$4.work(Transform.scala:67)
Error:  	at sbt.Execute.$anonfun$submit$2(Execute.scala:281)
Error:  	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:19)
Error:  	at sbt.Execute.work(Execute.scala:290)
Error:  	at sbt.Execute.$anonfun$submit$1(Execute.scala:281)
Error:  	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
Error:  	at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
Error:  	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
Error:  	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
Error:  	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
Error:  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
Error:  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
Error:  	at java.lang.Thread.run(Thread.java:748)
Error:  (update) sbt.librarymanagement.ResolveException: Error downloading org.xerial.sbt:sbt-pack;sbtVersion=1.0;scalaVersion=2.12:0.Error:    Not found
Error:    Not found
Error:    download error: Caught java.net.UnknownHostException: repo1.maven.org (repo1.maven.org) while downloading https://repo1.maven.org/maven2/org/xerial/sbt/sbt-pack_2.12_1.0/0.13/sbt-pack-0.13.pom
Error:    not found: /root/.ivy2/local/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/sbt-plugin-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/central/org/xerial/sbt/sbt-pack_2.12_1.0/0.13/sbt-pack-0.13.pom
Error:    not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:    not found: https://repo.typesafe.com/typesafe/ivy-releases/org.xerial.sbt/sbt-pack/scala_2.12/sbt_1.0/0.13/ivys/ivy.xml
Error:  Error downloading org.scala-js:scalajs-sbt-test-adapter_2.12:1.2.Error:    Not found
Error:    Not found
Error:    download error: Caught java.net.UnknownHostException: repo1.maven.org (repo1.maven.org) while downloading https://repo1.maven.org/maven2/org/scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/scalajs-sbt-test-adapter_2.12-1.2.0.pom
Error:    not found: /root/.ivy2/local/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/sbt-plugin-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://scala-webapps.epfl.ch/artifactory/central/org/scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/scalajs-sbt-test-adapter_2.12-1.2.0.pom
Error:    not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Error:    not found: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-js/scalajs-sbt-test-adapter_2.12/1.2.0/ivys/ivy.xml
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore? 
Error: Process completed with exit code 1.

@bishabosha
Copy link
Member Author

@sjrd updated it to special case the missing member addendum, so no longer generates symbols

@bishabosha bishabosha force-pushed the topic/enum-values-only-when-enumeration branch from cdb6a80 to 58e084e Compare October 15, 2020 11:48
sjrd
sjrd approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I love it.

@bishabosha
Copy link
Member Author

not sure whats happening, seems like the other ci jobs are hanging

@bishabosha bishabosha merged commit 8c56525 into scala:master Oct 15, 2020
@bishabosha bishabosha deleted the topic/enum-values-only-when-enumeration branch October 15, 2020 17:41
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@sjrd sjrd sjrd approved these changes

Assignees

@smarter smarter

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bishabosha @smarter @sjrd @Kordyjan